From 6e21be6523865eb03ba90f056b8dd260bf05d17a Mon Sep 17 00:00:00 2001
From: DiTus <ditus@o2.pl>
Date: Wed, 25 Feb 2026 23:52:50 +0100
Subject: [PATCH] Fix indicator panel UI bugs
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Fixed expand button not working (added data-id attribute)
- Removed duplicate empty Parameters section
- Fixed preset rendering (incorrect variable reference preset→p)
- Added resetIndicator function to reset params to defaults
- Added removeIndicator function tied to Remove button
- Fixed preset display bug causing reference error
---
 .../static/js/ui/indicators-panel-new.js      | 60 +++++++++----------
 1 file changed, 30 insertions(+), 30 deletions(-)

diff --git a/src/api/dashboard/static/js/ui/indicators-panel-new.js b/src/api/dashboard/static/js/ui/indicators-panel-new.js
index c6505bd..8d30383 100644
--- a/src/api/dashboard/static/js/ui/indicators-panel-new.js
+++ b/src/api/dashboard/static/js/ui/indicators-panel-new.js
@@ -238,7 +238,7 @@ function renderActiveIndicator(indicator) {
                 <button class="indicator-btn favorite" onclick="event.stopPropagation(); window.toggleFavorite && window.toggleFavorite('${indicator.type}')" title="Add to favorites">
                     ${isFavorite ? '★' : '☆'}
                 </button>
-                <button class="indicator-btn expand ${isExpanded ? 'rotated' : ''}" title="Show settings">
+                <button class="indicator-btn expand ${isExpanded ? 'rotated' : ''}" data-id="${indicator.id}" title="Show settings">
                     ${isExpanded ? '▼' : '▶'}
                 </button>
             </div>
@@ -320,31 +320,6 @@ function renderIndicatorConfig(indicator, meta) {
                     `).join('')}
                 </div>
             ` : ''}
-            </div>
-            
-            ${meta?.inputs && meta.inputs.length > 0 ? `
-                <div class="config-section">
-                    <div class="section-subtitle">Parameters</div>
-                    ${meta.inputs.map(input => `
-${console.log("[DEBUG] Input:", input.name, "value:", indicator.params[input.name])}`
-                            <label>${input.label}</label>
-                            ${input.type === 'select' ? 
-                                `<select onchange="window.updateIndicatorSetting && window.updateIndicatorSetting('${indicator.id}', '${input.name}', this.value)">
-                                    ${input.options.map(o => `<option value="${o}" ${indicator.params[input.name] === o ? 'selected' : ''}>${o}</option>`).join('')}
-                                </select>` :
-                                `<input 
-                                    type="number" 
-                                    value="${indicator.params[input.name]}" 
-                                    ${input.min !== undefined ? `min="${input.min}"` : ''} 
-                                    ${input.max !== undefined ? `max="${input.max}"` : ''} 
-                                    ${input.step !== undefined ? `step="${input.step}"` : ''} 
-                                    onchange="window.updateIndicatorSetting && window.updateIndicatorSetting('${indicator.id}', '${input.name}', parseFloat(this.value))"
-                                >`
-                            }
-                        </div>
-                    `).join('')}
-                </div>
-            ` : ''}
             
             <div class="config-section">
                 <div class="section-subtitle">
@@ -369,13 +344,13 @@ function renderIndicatorPresets(indicator, meta) {
         <div class="presets-list">
             ${presets.map(p => {
                 const isApplied = meta.inputs.every(input => 
-                    (indicator.params[input.name] === (preset.values?.[input.name] ?? input.default))
+                    (indicator.params[input.name] === (p.values?.[input.name] ?? input.default))
                 );
                 
                 return `
-                    <div class="preset-item ${isApplied ? 'applied' : ''}" data-preset="${preset.id}">
-                        <span class="preset-label" onclick="window.applyPreset && window.applyPreset('${indicator.id}', '${preset.id}')">${preset.name}</span>
-                        <button class="preset-delete" onclick="window.deletePreset && window.deletePreset('${preset.id}')">×</button>
+                    <div class="preset-item ${isApplied ? 'applied' : ''}" data-preset="${p.id}">
+                        <span class="preset-label" onclick="window.applyPreset && window.applyPreset('${indicator.id}', '${p.id}')">${p.name}</span>
+                        <button class="preset-delete" onclick="window.deletePreset && window.deletePreset('${p.id}')">×</button>
                     </div>
                 `;
             }).join('')}
@@ -851,11 +826,36 @@ export function drawIndicatorsOnChart() {
     });
 }
 
+function resetIndicator(id) {
+    const indicator = activeIndicators.find(a => a.id === id);
+    if (!indicator) return;
+    
+    const IndicatorClass = IR[indicator.type];
+    if (!IndicatorClass) return;
+    
+    const instance = new IndicatorClass({ type: indicator.type, params: {}, name: '' });
+    const meta = instance.getMetadata();
+    if (!meta || !meta.inputs) return;
+    
+    meta.inputs.forEach(input => {
+        indicator.params[input.name] = input.default;
+    });
+    
+    renderIndicatorPanel();
+    drawIndicatorsOnChart();
+}
+
+function removeIndicator(id) {
+    removeIndicatorById(id);
+}
+
 // Export functions for module access
 export { addIndicator, removeIndicatorById };
 
 // Legacy compatibility functions
 window.renderIndicatorList = renderIndicatorPanel;
+window.resetIndicator = resetIndicator;
+window.removeIndicator = removeIndicator;
 window.toggleIndicator = addIndicator;
 window.showIndicatorConfig = function(id) {
     const ind = activeIndicators.find(a => a.id === id);